AMQ-9162 Fix WS transport start via JMX after it was closed. #1370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cshannon
requested changes
Dec 17, 2024
jbonofre
requested changes
Dec 19, 2024
|
|
||
| server.start(); | ||
| ClassLoader original = Thread.currentThread().getContextClassLoader(); | ||
| Thread.currentThread().setContextClassLoader(WSTransportServer.class.getClassLoader()); |
There was a problem hiding this comment.
This could be problematic in OSGi/Karaf generally speaking. In this specific it should be ok as the WSTransportServer is in the activemq-osgi bundle.
Nikita-Shupletsov
force-pushed
the
ws_jmx_start_fix
branch
from
17ff563 to
016f3e2
Compare
sorry for that, removed |
jbonofre
approved these changes
Sep 29, 2025
|
@cshannon I did a new pass (including OSGi) and this looks good to me. Do you mind to take a new look and maybe remove your -1 ? |
|
@jbonofre should this be re-targeted to activemq-5.19.x? |
|
@mattrpav yes, that makes sense to include the fix in 5.19.x as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it was discussed in the ticket, the issue exists only in 5.x versions, hence the PR is only to the 5.18.x branch.
Also added a test that reproduces the issue without the fix.