Skip to content

Commit

Permalink
fix failing test_sensitive_values unit test
Browse files Browse the repository at this point in the history
  • Loading branch information
Owen-CH-Leung committed Sep 21, 2024
1 parent e9f16c3 commit 52d3a00
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion tests/core/test_configuration.py
Original file line number Diff line number Diff line change
Expand Up @@ -1609,14 +1609,15 @@ def test_sensitive_values():
("celery", "broker_url"),
("celery", "flower_basic_auth"),
("celery", "result_backend"),
("opensearch", "username"),
("opensearch", "password"),
}
all_keys = {(s, k) for s, v in conf.configuration_description.items() for k in v.get("options")}
suspected_sensitive = {(s, k) for (s, k) in all_keys if k.endswith(("password", "kwargs"))}
exclude_list = {
("aws_batch_executor", "submit_job_kwargs"),
("kubernetes_executor", "delete_option_kwargs"),
("aws_ecs_executor", "run_task_kwargs"), # Only a constrained set of values, none are sensitive
("opensearch", "password"),
}
suspected_sensitive -= exclude_list
sensitive_values.update(suspected_sensitive)
Expand Down

0 comments on commit 52d3a00

Please sign in to comment.