Fix AWS Connection warn condition for invalid profile_name argument (…

…#26464)
apache · Sep 19, 2022 · a2b186a · a2b186a
1 parent 4930df4
commit a2b186a
Showing 1 changed file with 9 additions and 9 deletions.
diff --git a/airflow/providers/amazon/aws/utils/connection_wrapper.py b/airflow/providers/amazon/aws/utils/connection_wrapper.py
@@ -177,15 +177,15 @@ def __post_init__(self, conn: Connection):
             )
 
         # Warn the user that an invalid parameter is being used which actually not related to 'profile_name'.
-        if "profile" in extra and "s3_config_file" not in extra:
-            if "profile_name" not in self.session_kwargs:
-                warnings.warn(
-                    f"Found 'profile' without specifying 's3_config_file' in {self.conn_repr} extra. "
-                    "If required profile from AWS Shared Credentials please "
-                    f"set 'profile_name' in {self.conn_repr} extra['session_kwargs'].",
-                    UserWarning,
-                    stacklevel=2,
-                )
+        # ToDo: Remove this check entirely as soon as drop support credentials from s3_config_file
+        if "profile" in extra and "s3_config_file" not in extra and not self.profile_name:
+            warnings.warn(
+                f"Found 'profile' without specifying 's3_config_file' in {self.conn_repr} extra. "
+                "If required profile from AWS Shared Credentials please "
+                f"set 'profile_name' in {self.conn_repr} extra.",
+                UserWarning,
+                stacklevel=2,
+            )
 
         config_kwargs = extra.get("config_kwargs")
         if not self.botocore_config and config_kwargs: