Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcom view broken for non-JSON values #41981

Closed
1 of 2 tasks
jkramer-ginkgo opened this issue Sep 3, 2024 · 6 comments
Closed
1 of 2 tasks

Xcom view broken for non-JSON values #41981

jkramer-ginkgo opened this issue Sep 3, 2024 · 6 comments
Labels
area:core area:UI Related to UI/UX. For Frontend Developers. duplicate Issue that is duplicated kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet

Comments

@jkramer-ginkgo
Copy link
Contributor

Apache Airflow version

2.10.0

If "Other Airflow 2 version" selected, which one?

No response

What happened?

Non-JSON values are broken in the Xcom UI [screenshot attached]

Root cause is this line from #40640. Setting stringify: false results in JSON encoding which results in TypeError: keys must be str, int, float, bool or None, not tuple exception from GET <Airflow URL>/api/v1/dags/<DAG>/dagRuns/<Run ID>/taskInstances/<Task ID>/xcomEntries/<Xcom name>?stringify=false endpoint.

The PR's intention is to make the whole view JSON, so not sure if the intention is to error on non-JSON Xcom values, or if it should be updated to have clean fallback logic.

Pasted Graphic 22

What you think should happen instead?

No response

How to reproduce

Create Xcom value that is non-JSON serializable (e.g. {('201009_NB502104_0421_AHJY23BGXG (SEQ_WF: 138898)', None): 82359}) and then try to view in UI Xcom tab

Operating System

Linux (Ubuntu 22.04)

Versions of Apache Airflow Providers

No response

Deployment

Virtualenv installation

Deployment details

No response

Anything else?

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@jkramer-ginkgo jkramer-ginkgo added area:core kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet labels Sep 3, 2024
@dosubot dosubot bot added the area:UI Related to UI/UX. For Frontend Developers. label Sep 3, 2024
@potiuk
Copy link
Member

potiuk commented Sep 3, 2024

Duplicate of #41605 fixed in #41516 and available in 2.10.1rc1. Can you please double check if rc1 of 2.10.0 fixes the problem for you @jkramer-ginkgo - see #41956 for links and details

@potiuk potiuk closed this as completed Sep 3, 2024
@potiuk
Copy link
Member

potiuk commented Sep 3, 2024

Ideally pleasee comment in #41956 when you confirm the problem is fixed.

@potiuk potiuk added the duplicate Issue that is duplicated label Sep 3, 2024
@jkramer-ginkgo
Copy link
Contributor Author

@potiuk It is still broken in 2.10.1.. I should've mentioned I had tested against a manually patched version with #41605

@jkramer-ginkgo
Copy link
Contributor Author

@potiuk would you be able to reopen or should I dupe this issue?

@potiuk
Copy link
Member

potiuk commented Sep 9, 2024

Idealy copy it - this is easier for our "release" process.

@jkramer-ginkgo
Copy link
Contributor Author

@potiuk Cloned here: #42117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core area:UI Related to UI/UX. For Frontend Developers. duplicate Issue that is duplicated kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet
Projects
None yet
Development

No branches or pull requests

2 participants