-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xcom view broken for non-JSON values #42117
Comments
I tried to reproduce this if it is fixed with another fix I did in 2.10.2(rc1) but failed creating the XCom.
I get the error How did you generate the data or can you please paste a piece of the example how you generated it? |
Maybe there's some diff between our configs and/or DAG-style but this xcom is properly being set and used. The dag is set up using [example]
|
Yes, we have |
Oh yeah. With |
Apache Airflow version
Other Airflow 2 version (please specify below)
If "Other Airflow 2 version" selected, which one?
2.10.1
What happened?
Non-JSON values are broken in the Xcom UI [screenshot attached]
Root cause is this line from #40640. Setting
stringify: false
results in JSON encoding which results inTypeError: keys must be str, int, float, bool or None, not tuple
exception fromGET <Airflow URL>/api/v1/dags/<DAG>/dagRuns/<Run ID>/taskInstances/<Task ID>/xcomEntries/<Xcom name>?stringify=false
endpoint.The PR's intention is to make the whole view JSON, so not sure if the intention is to error on non-JSON Xcom values, or if it should be updated to have clean fallback logic.
[This is a dupe of #41981]
What you think should happen instead?
No response
How to reproduce
Create Xcom value that is non-JSON serializable (e.g.
{('201009_NB502104_0421_AHJY23BGXG (SEQ_WF: 138898)', None): 82359}
) and then try to view in UI Xcom tabOperating System
Linux (Ubuntu 22.04)
Versions of Apache Airflow Providers
No response
Deployment
Virtualenv installation
Deployment details
No response
Anything else?
No response
Are you willing to submit PR?
Code of Conduct
The text was updated successfully, but these errors were encountered: