FastAPI API Add test query params standardization an reusability

[pierrejeambrun]

Related to: #42159

This will abstract the handling of common FIlters, Search and Sort query param so we do not have to copy and past the same query.where(...) on all endpoints that are using this same logic.

This allows:

• To remove some logic from the views, and only keep http related thing. (serialization/deserialization, query param validation, etc...). Aim for a more layed and decouple AIP code. (hexagonal / onion architecture is an inspiration, but that's too early and not a priority). Cf the custom code removed from the get_dags view.
• Initialize some reusable logic for the db layer
• Will allow to add more complex filters that cannot be done today, especially on the order_by because we were using a sqlalchemy text clause that do not work with hybrid properties. (cf follow up PR to add ordering by dag_display_name)

The goal is to have that extended and have a library of query params that can be re-used accross all the RestAPI.

[jedcunningham]

Suggested change

return select

This will never be hit, the else will.

[jedcunningham]

Suggested change

	if self.value:
	conditions = [DagModel.tags.any(DagTag.name == tag) for tag in self.value]
	return select.where(or_(*conditions))
	return select
	if self.value is None:
	return select
	conditions = [DagModel.tags.any(DagTag.name == tag) for tag in self.value]
	return select.where(or_(*conditions))

Keep it consistent with the others, plus short circuiting out is easier to read imo.

[jedcunningham]

Suggested change

	self.value = offset
	return self
	return self.set_value(offset)

[jedcunningham]

Suggested change

	self.value = limit
	return self
	return self.set_value(limit)

[jedcunningham]

Should move these into the if TYPE_CHECKING block below, no?

[jscheffl]

Would not ruff tell you so :-D

[jedcunningham]

Suggested change

	from fastapi import Depends, HTTPException, Query as Query
	from fastapi import Depends, HTTPException, Query

[jscheffl]

Does this chane not create the requirement to always pass at least an empty array and does not allow skipping this filter? Is this a breaking change or do I mis-interpret?

[jscheffl]

+1 but then it needs to be:

Suggested change

	else:
	return select.order_by(getattr(DagModel, lstriped_orderby).asc())
	return select
	return select.order_by(getattr(DagModel, lstriped_orderby).asc())

[jscheffl]

Learning some Python magic every day. That query stuff smells like black magic... but looks cool!