Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor _register_dataset_changes #42343

Merged
merged 11 commits into from
Sep 25, 2024

Commits on Sep 20, 2024

  1. Reduce database calls in _register_dataset_changes

    Instead of fetching DatasetModel one by one, do a bulk fetch into a dict
    to save roundtrips to the database.
    uranusjr committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    0f52eec View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a65e3e7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a167889 View commit details
    Browse the repository at this point in the history
  4. Create dataset things only in DatasetManager

    Prior to this commit, we already only create DatasetModel rows inside
    the manager. This also changes how DatasetAliasModel to only be created
    inside create_dataset_aliases, and only associated them to DatasetEvent
    in register_dataset_change.
    
    All the dataset manager functions are also changed to only accept
    public-facing dataset classes, instead of ORM models.
    
    The register_dataset_change function now takes an additional keyword
    argument 'aliases' that is a list of dataset aliases associated to the
    DatasetEvent to be created.
    uranusjr committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    b8888bb View commit details
    Browse the repository at this point in the history
  5. Create dataset things only in DatasetManager

    Prior to this commit, we already only create DatasetModel rows inside
    the manager. This also changes how DatasetAliasModel to only be created
    inside create_dataset_aliases, and only associated them to DatasetEvent
    in register_dataset_change.
    
    All the dataset manager functions are also changed to only accept
    public-facing dataset classes, instead of ORM models.
    
    The register_dataset_change function now takes an additional keyword
    argument 'aliases' that is a list of dataset aliases associated to the
    DatasetEvent to be created.
    uranusjr committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    7bd6274 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a106a8a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    8179e9b View commit details
    Browse the repository at this point in the history
  8. Change news fragment name

    uranusjr committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    39b3c51 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Configuration menu
    Copy the full SHA
    a534051 View commit details
    Browse the repository at this point in the history
  2. Keep it simple(r)

    uranusjr committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    bbc2289 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Configuration menu
    Copy the full SHA
    59d75c5 View commit details
    Browse the repository at this point in the history