-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor _register_dataset_changes #42343
Merged
uranusjr
merged 11 commits into
apache:main
from
astronomer:refactor-register-dataset-changes
Sep 25, 2024
Merged
Refactor _register_dataset_changes #42343
uranusjr
merged 11 commits into
apache:main
from
astronomer:refactor-register-dataset-changes
Sep 25, 2024
Commits on Sep 20, 2024
-
Reduce database calls in _register_dataset_changes
Instead of fetching DatasetModel one by one, do a bulk fetch into a dict to save roundtrips to the database.
Configuration menu - View commit details
-
Copy full SHA for 0f52eec - Browse repository at this point
Copy the full SHA 0f52eecView commit details -
Configuration menu - View commit details
-
Copy full SHA for a65e3e7 - Browse repository at this point
Copy the full SHA a65e3e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for a167889 - Browse repository at this point
Copy the full SHA a167889View commit details -
Create dataset things only in DatasetManager
Prior to this commit, we already only create DatasetModel rows inside the manager. This also changes how DatasetAliasModel to only be created inside create_dataset_aliases, and only associated them to DatasetEvent in register_dataset_change. All the dataset manager functions are also changed to only accept public-facing dataset classes, instead of ORM models. The register_dataset_change function now takes an additional keyword argument 'aliases' that is a list of dataset aliases associated to the DatasetEvent to be created.
Configuration menu - View commit details
-
Copy full SHA for b8888bb - Browse repository at this point
Copy the full SHA b8888bbView commit details -
Create dataset things only in DatasetManager
Prior to this commit, we already only create DatasetModel rows inside the manager. This also changes how DatasetAliasModel to only be created inside create_dataset_aliases, and only associated them to DatasetEvent in register_dataset_change. All the dataset manager functions are also changed to only accept public-facing dataset classes, instead of ORM models. The register_dataset_change function now takes an additional keyword argument 'aliases' that is a list of dataset aliases associated to the DatasetEvent to be created.
Configuration menu - View commit details
-
Copy full SHA for 7bd6274 - Browse repository at this point
Copy the full SHA 7bd6274View commit details -
Configuration menu - View commit details
-
Copy full SHA for a106a8a - Browse repository at this point
Copy the full SHA a106a8aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8179e9b - Browse repository at this point
Copy the full SHA 8179e9bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 39b3c51 - Browse repository at this point
Copy the full SHA 39b3c51View commit details
Commits on Sep 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a534051 - Browse repository at this point
Copy the full SHA a534051View commit details -
Configuration menu - View commit details
-
Copy full SHA for bbc2289 - Browse repository at this point
Copy the full SHA bbc2289View commit details
Commits on Sep 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 59d75c5 - Browse repository at this point
Copy the full SHA 59d75c5View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.