Refactor ORM DAG insertion logic #42358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
requested review from
jedcunningham,
ephraimbuddy,
kaxil,
XD-DENG and
ashb
as code owners
boring-cyborg
bot
added
the
area:Scheduler
uranusjr
force-pushed
the
refactor-orm-dag-add
branch
from
c4d45d8
to
52b7cdd
Compare
Basically using the same pattern as the dataset inserts. Making fk relation updates more readable. The SQL queries CAN be made more efficient, but I decided to keep things as-is (not worse than before). These are likely not that big a deal.
uranusjr
force-pushed
the
refactor-orm-dag-add
branch
from
52b7cdd
to
28c8db5
Compare
Lee-W
reviewed
Sep 23, 2024
Lee-W
reviewed
Sep 23, 2024
Lee-W
approved these changes
Sep 23, 2024
joaopamaral
pushed a commit
to joaopamaral/airflow
that referenced
this pull request
Oct 21, 2024
* Refactor ORM DAG insertion logic Basically using the same pattern as the dataset inserts. Making fk relation updates more readable. The SQL queries CAN be made more efficient, but I decided to keep things as-is (not worse than before). These are likely not that big a deal. * Use set operation for readability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically using the same pattern as the dataset inserts. Making fk relation updates more readable.
The SQL queries CAN be made more efficient, but I decided to keep things as-is (not worse than before). These are likely not that big a deal.