Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce max length of pre-commit hooks #42384

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

dstandish
Copy link
Contributor

@dstandish dstandish commented Sep 20, 2024

This is just to ensure that we get each hook on a single line when running in split pane on macbook pro 14".

E.g. avoids this ugliness

image

Where we need to add more details, we can use the description field.

This is just to ensure that we get each hook on a single line when running in split pain on macbook pro 14".
Copy link
Member

@jedcunningham jedcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it. The perfect Friday PR.

@jedcunningham jedcunningham merged commit c946846 into apache:main Sep 20, 2024
52 checks passed
@jedcunningham jedcunningham deleted the limit-pre-commit-name-length branch September 20, 2024 20:29
@potiuk
Copy link
Member

potiuk commented Oct 1, 2024

nice

joaopamaral pushed a commit to joaopamaral/airflow that referenced this pull request Oct 21, 2024
This is just to ensure that we get each hook on a single line when running in split pane on macbook pro 14".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants