Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not attempt to provide not stringified objects to UI via xcom if pickling is active #42388

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

jscheffl
Copy link
Contributor

With this PR the xcom will always be returned as string if XCom pickling is active. Like it was in Airflow 2.9.

closes: #42117

@boring-cyborg boring-cyborg bot added the area:API Airflow's REST/HTTP API label Sep 20, 2024
@jscheffl jscheffl added this to the Airflow 2.10.3 milestone Sep 20, 2024
@jscheffl jscheffl added the area:UI Related to UI/UX. For Frontend Developers. label Sep 20, 2024
Copy link
Contributor

@shahar1 shahar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a test? :)

@jkramer-ginkgo
Copy link
Contributor

It would be great to instead have the React JSON view enabled for JSON-serializable Xcom values, and fall back to old logic otherwise. I can try taking a crack at that next week.

@jscheffl jscheffl force-pushed the bugfix/xcon-display-if-xcom-is-pickled branch from 3583fb5 to de23033 Compare September 21, 2024 17:09
@jscheffl
Copy link
Contributor Author

It would be great to instead have the React JSON view enabled for JSON-serializable Xcom values, and fall back to old logic otherwise. I can try taking a crack at that next week.

Yeah. You can try. We can keep the PR open or you add another PR on top to improve.

Unfortunately the JSON serialization is handled by the underlying framework such that the error is created post return. The only (simple) option that I see is to attempt a serialization and if this is OK then return is native, stryingify as fallback? But then the resulting object needs to be serialized multiple times. Mhm not really good.

@jscheffl jscheffl merged commit f9877af into apache:main Sep 25, 2024
55 checks passed
jscheffl added a commit to jscheffl/airflow that referenced this pull request Sep 25, 2024
…ickling is active (apache#42388)

* Do not attempt to provide not stringified objects to UI via xcom if pickling is active

* Add pytest

(cherry picked from commit f9877af)
@jscheffl jscheffl added the type:bug-fix Changelog: Bug Fixes label Sep 25, 2024
jscheffl added a commit that referenced this pull request Sep 26, 2024
…ickling is active (#42388) (#42486)

* Do not attempt to provide not stringified objects to UI via xcom if pickling is active

* Add pytest

(cherry picked from commit f9877af)
joaopamaral pushed a commit to joaopamaral/airflow that referenced this pull request Oct 21, 2024
…ickling is active (apache#42388)

* Do not attempt to provide not stringified objects to UI via xcom if pickling is active

* Add pytest
utkarsharma2 pushed a commit that referenced this pull request Oct 23, 2024
…ickling is active (#42388) (#42486)

* Do not attempt to provide not stringified objects to UI via xcom if pickling is active

* Add pytest

(cherry picked from commit f9877af)
utkarsharma2 pushed a commit that referenced this pull request Oct 24, 2024
…ickling is active (#42388) (#42486)

* Do not attempt to provide not stringified objects to UI via xcom if pickling is active

* Add pytest

(cherry picked from commit f9877af)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Xcom view broken for non-JSON values
4 participants