Add slack notification for canary build failures #42394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romsharon98
changed the title
jscheffl
approved these changes
Sep 25, 2024
romsharon98
force-pushed
the
cicd/add-slack-notifications
branch
from
b8c52fd
to
a2f2724
Compare
romsharon98
force-pushed
the
cicd/add-slack-notifications
branch
from
a2f2724
to
781fd86
Compare
jscheffl
force-pushed
the
cicd/add-slack-notifications
branch
from
781fd86
to
e980d50
Compare
jedcunningham
approved these changes
Sep 26, 2024
romsharon98
force-pushed
the
cicd/add-slack-notifications
branch
from
e980d50
to
cc8c15f
Compare
|
Seems we have a bug in the logic... with my limited Github actions knowledge... I assume dependecy is missing and therefore it is skipped as no failure is made at point of the task is activated and then decides to skip.
|
joaopamaral
pushed a commit
to joaopamaral/airflow
that referenced
this pull request
Oct 21, 2024
* add slack notifier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #42203
this PR should send message to this slack channel https://apache-airflow.slack.com/archives/C07MWFASWJ1 if the CI is failed.
after verification on the main branch we need to change the alerts to be sent to the internal-ci-cd channel.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.