Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling TLS arguments for FastAPI #42395

Merged
merged 2 commits into from
Sep 22, 2024
Merged

Enabling TLS arguments for FastAPI #42395

merged 2 commits into from
Sep 22, 2024

Conversation

JoshuaXOng
Copy link
Contributor

Passing SSL arguments down to process invocation for fastapi-api.

Have erred to leave a couple things untouched (for the moment at least).

related: 42359


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link

boring-cyborg bot commented Sep 21, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

Copy link
Contributor

@shahar1 shahar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome and thanks for your contribution!
Got a few comments :)

tests/cli/commands/test_fastapi_api_command.py Outdated Show resolved Hide resolved
tests/cli/commands/test_fastapi_api_command.py Outdated Show resolved Hide resolved
airflow/cli/commands/fastapi_api_command.py Show resolved Hide resolved
@shahar1 shahar1 added this to the Airflow 3.0.0 milestone Sep 22, 2024
@shahar1 shahar1 added type:new-feature Changelog: New Features type:improvement Changelog: Improvements and removed type:new-feature Changelog: New Features labels Sep 22, 2024
@shahar1 shahar1 merged commit d751bd8 into apache:main Sep 22, 2024
38 checks passed
Copy link

boring-cyborg bot commented Sep 22, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

joaopamaral pushed a commit to joaopamaral/airflow that referenced this pull request Oct 21, 2024
* Added TLS arguments for FastAPI

* Uplifted FastAPI TLS tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:CLI type:improvement Changelog: Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants