-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling TLS arguments for FastAPI #42395
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome and thanks for your contribution!
Got a few comments :)
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
* Added TLS arguments for FastAPI * Uplifted FastAPI TLS tests
Passing SSL arguments down to process invocation for
fastapi-api
.Have erred to leave a couple things untouched (for the moment at least).
gunicorn
has some odd logs (UI API CLI and Breeze integration #41896). Have assumed the intent for now is to keep debug usingfastapi
.fastapi
cli does not seem to have flags for SSL/TLS.airflow/airflow/cli/commands/internal_api_command.py
, have inferred from UI API CLI and Breeze integration #41896 that they're kinda separaterelated: 42359
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.