Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade databricks provider dependency databricks-sql-connector to support version >= 3.0 #42626

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rubanolha
Copy link

@rubanolha rubanolha commented Oct 1, 2024

Updated the dependency constraint for databricks-sql-connector for databricks provider. It updates the databricks-sql-connector dependency to support version >= 3.0 which is released on Nov 17, 2023.
Upgrading to version >= 3.0 is crucial for compatibility with other packages, especially dbt, and resolves a blocker impacting many users' workflows.
closes: #39274


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link

boring-cyborg bot commented Oct 1, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@rubanolha
Copy link
Author

As sqlalchemy is optional for databricks-sql-connector starting from v3.0.0, the expectation that it will not be blocked by deprecations of SQLAlchemy 2.

@potiuk potiuk force-pushed the olharuban/upgrade_databricks_prodiver_dependency_version branch from 90fe760 to 305493b Compare October 4, 2024 01:46
@rubanolha rubanolha requested a review from potiuk October 4, 2024 17:45
@rubanolha rubanolha force-pushed the olharuban/upgrade_databricks_prodiver_dependency_version branch from ba21e2e to 18fcfbb Compare October 9, 2024 20:20
@potiuk
Copy link
Member

potiuk commented Oct 13, 2024

Checks are failing

@potiuk potiuk force-pushed the olharuban/upgrade_databricks_prodiver_dependency_version branch from 867bf78 to 9eb97e2 Compare October 17, 2024 22:48
@dcmshi dcmshi force-pushed the olharuban/upgrade_databricks_prodiver_dependency_version branch from b466dd3 to 2a9b496 Compare October 22, 2024 19:13
@potiuk
Copy link
Member

potiuk commented Oct 24, 2024

You need to rebase, and fix static checks that are resulting from switching to the new databricks provider.

@potiuk potiuk force-pushed the olharuban/upgrade_databricks_prodiver_dependency_version branch from 2a9b496 to 23a999d Compare October 28, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Databricks provider to depend on databricks-sql-connector >= 3.1.0
3 participants