Add Trigger DAG UI with advance options #43367
Conversation
|
@jscheffl Tried to cover many points. Still some points left.
|
shubhamraj-git
force-pushed
the
trigger-ui
branch
from
98d83cf
to
042947b
Compare
shubhamraj-git
force-pushed
the
trigger-ui
branch
from
2fad497
to
e910c44
Compare
|
Oh you already rebased? How was moving your changes to chakra v3? |
|
@bbovenzi |
|
Ok. Let me know if you want me to pull the branch down and help with the rebase. |
shubhamraj-git
force-pushed
the
trigger-ui
branch
from
e910c44
to
a9104d6
Compare
shubhamraj-git
requested review from
pierrejeambrun and
ryanahamilton
as code owners
shubhamraj-git
changed the title
shubhamraj-git
changed the title
| </Heading> | ||
| {isPaused ? ( | ||
| <Alert status="warning" title="Paused DAG"> | ||
| You can not trigger a paused DAG, Unpause DAG to trigger |
There was a problem hiding this comment.
| You can not trigger a paused DAG, Unpause DAG to trigger | |
| Dag is paused. Triggering will create a Dag run but it won't start until the Dag is unpaused. |
There was a problem hiding this comment.
So, should we remove the disable trigger button on paused DAG? Since the wording let user trigger it.
There was a problem hiding this comment.
Since, we have a title "Paused DAG"
Let's Include just "Triggering will create a Dag run but it won't start until the Dag is unpaused." in the subject ?
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.