Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bundle name arg to list dags cli command #45779

Merged
merged 20 commits into from
Feb 28, 2025

Conversation

ambika-garg
Copy link
Contributor

@ambika-garg ambika-garg commented Jan 18, 2025

closes: #45646


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@jedcunningham jedcunningham self-requested a review January 20, 2025 02:29
@jscheffl jscheffl added the legacy api Whether legacy API changes should be allowed in PR label Jan 26, 2025
@ambika-garg ambika-garg force-pushed the open-source-2 branch 3 times, most recently from 7b4d630 to 303d6c3 Compare February 5, 2025 03:40
@ambika-garg ambika-garg marked this pull request as ready for review February 5, 2025 04:18
@jedcunningham
Copy link
Member

@ambika-garg, check our #46571 which just made it so more than 1 bundle can be passed via the cli. You'll need to refactor a tiny bit to support that here.

@ambika-garg
Copy link
Contributor Author

@ambika-garg, check our #46571 which just made it so more than 1 bundle can be passed via the cli. You'll need to refactor a tiny bit to support that here.

Screenshot 2025-02-08 at 4 55 51 PM

Copy link
Member

@jedcunningham jedcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Think we need some cycles on tests though.

@ambika-garg
Copy link
Contributor Author

Overall looks good. Think we need some cycles on tests though.

I've fixed the test, it works fine now. Please review it once. I think now PR looks good.

ambika-garg and others added 20 commits February 27, 2025 19:21
* Fix the list_dags function, to filter the dags by bundle name
@jedcunningham jedcunningham merged commit 22da959 into apache:main Feb 28, 2025
89 checks passed
@jedcunningham
Copy link
Member

Thanks @ambika-garg!

Sharashchandra pushed a commit to Sharashchandra/airflow that referenced this pull request Feb 28, 2025
@ambika-garg ambika-garg deleted the open-source-2 branch February 28, 2025 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AIP-66: DAG Bundle/Manifest area:CLI legacy api Whether legacy API changes should be allowed in PR
Projects
Development

Successfully merging this pull request may close these issues.

Add bundle_name and latest_bundle_version to dags list command
4 participants