-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit ydb to < 3.19.0 #47105
Merged
Merged
Limit ydb to < 3.19.0 #47105
+13
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ydb 3.19.0 wrongly states it compatibility with grpc.io and it caused our tests to fail as it conflicts with apache.beam < 1.66. Temporarily limiting it now, deferring final solution(s) to: * apache/beam#34081 or * https://github.com/ydb-platform/ydb/issues/15087
gopidesupavan
approved these changes
Feb 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
amoghrajesh
approved these changes
Feb 26, 2025
vincbeck
approved these changes
Feb 26, 2025
Merging as it passed the failing tests in #46942 |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Feb 27, 2025
The apache#47105 wrongly assumed that the new ydb version caused the problem with grpc.io, it turned out however that the root cause was wrong grpcio specification for yandexcloud - where grpcio requirement did not match runtime check for version. Excluding the versions of yandexcloud (and asking them to yank those versions) should help in solving the problem and it should not limit users to upgrade to newer versions of yandexcloud (when they are not using apache.beam or other libraries that limit grpcio to < 1.68.1)
This was referenced Feb 27, 2025
eladkal
pushed a commit
that referenced
this pull request
Feb 27, 2025
The #47105 wrongly assumed that the new ydb version caused the problem with grpc.io, it turned out however that the root cause was wrong grpcio specification for yandexcloud - where grpcio requirement did not match runtime check for version. Excluding the versions of yandexcloud (and asking them to yank those versions) should help in solving the problem and it should not limit users to upgrade to newer versions of yandexcloud (when they are not using apache.beam or other libraries that limit grpcio to < 1.68.1)
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 28, 2025
Ydb 3.19.0 wrongly states it compatibility with grpc.io and it caused our tests to fail as it conflicts with apache.beam < 1.66. Temporarily limiting it now, deferring final solution(s) to: * apache/beam#34081 or * https://github.com/ydb-platform/ydb/issues/15087
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 28, 2025
The apache#47105 wrongly assumed that the new ydb version caused the problem with grpc.io, it turned out however that the root cause was wrong grpcio specification for yandexcloud - where grpcio requirement did not match runtime check for version. Excluding the versions of yandexcloud (and asking them to yank those versions) should help in solving the problem and it should not limit users to upgrade to newer versions of yandexcloud (when they are not using apache.beam or other libraries that limit grpcio to < 1.68.1)
Sharashchandra
pushed a commit
to Sharashchandra/airflow
that referenced
this pull request
Feb 28, 2025
The apache#47105 wrongly assumed that the new ydb version caused the problem with grpc.io, it turned out however that the root cause was wrong grpcio specification for yandexcloud - where grpcio requirement did not match runtime check for version. Excluding the versions of yandexcloud (and asking them to yank those versions) should help in solving the problem and it should not limit users to upgrade to newer versions of yandexcloud (when they are not using apache.beam or other libraries that limit grpcio to < 1.68.1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ydb 3.19.0 wrongly states it compatibility with grpc.io and it caused our tests to fail as it conflicts with apache.beam < 1.66.
Temporarily limiting it now, deferring final solution(s) to:
or
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.