Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit ydb to < 3.19.0 #47105

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Feb 26, 2025

Ydb 3.19.0 wrongly states it compatibility with grpc.io and it caused our tests to fail as it conflicts with apache.beam < 1.66.

Temporarily limiting it now, deferring final solution(s) to:

or


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Ydb 3.19.0 wrongly states it compatibility with grpc.io and it
caused our tests to fail as it conflicts with apache.beam < 1.66.

Temporarily limiting it now, deferring final solution(s) to:

* apache/beam#34081

or

* https://github.com/ydb-platform/ydb/issues/15087
Copy link
Member

@gopidesupavan gopidesupavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@potiuk potiuk merged commit c0c7614 into apache:main Feb 26, 2025
108 of 112 checks passed
@potiuk potiuk deleted the workaround-ydb-grpcio-mismatch branch February 26, 2025 15:42
@potiuk
Copy link
Member Author

potiuk commented Feb 26, 2025

Merging as it passed the failing tests in #46942

potiuk added a commit to potiuk/airflow that referenced this pull request Feb 27, 2025
The apache#47105 wrongly assumed that the new ydb version caused the problem
with grpc.io, it turned out however that the root cause was wrong
grpcio specification for yandexcloud - where grpcio requirement
did not match runtime check for version.

Excluding the versions of yandexcloud (and asking them to yank those
versions) should help in solving the problem and it should not
limit users to upgrade to newer versions of yandexcloud (when they
are not using apache.beam or other libraries that limit grpcio to
< 1.68.1)
eladkal pushed a commit that referenced this pull request Feb 27, 2025
The #47105 wrongly assumed that the new ydb version caused the problem
with grpc.io, it turned out however that the root cause was wrong
grpcio specification for yandexcloud - where grpcio requirement
did not match runtime check for version.

Excluding the versions of yandexcloud (and asking them to yank those
versions) should help in solving the problem and it should not
limit users to upgrade to newer versions of yandexcloud (when they
are not using apache.beam or other libraries that limit grpcio to
< 1.68.1)
ambika-garg pushed a commit to ambika-garg/airflow that referenced this pull request Feb 28, 2025
Ydb 3.19.0 wrongly states it compatibility with grpc.io and it
caused our tests to fail as it conflicts with apache.beam < 1.66.

Temporarily limiting it now, deferring final solution(s) to:

* apache/beam#34081

or

* https://github.com/ydb-platform/ydb/issues/15087
ambika-garg pushed a commit to ambika-garg/airflow that referenced this pull request Feb 28, 2025
The apache#47105 wrongly assumed that the new ydb version caused the problem
with grpc.io, it turned out however that the root cause was wrong
grpcio specification for yandexcloud - where grpcio requirement
did not match runtime check for version.

Excluding the versions of yandexcloud (and asking them to yank those
versions) should help in solving the problem and it should not
limit users to upgrade to newer versions of yandexcloud (when they
are not using apache.beam or other libraries that limit grpcio to
< 1.68.1)
Sharashchandra pushed a commit to Sharashchandra/airflow that referenced this pull request Feb 28, 2025
The apache#47105 wrongly assumed that the new ydb version caused the problem
with grpc.io, it turned out however that the root cause was wrong
grpcio specification for yandexcloud - where grpcio requirement
did not match runtime check for version.

Excluding the versions of yandexcloud (and asking them to yank those
versions) should help in solving the problem and it should not
limit users to upgrade to newer versions of yandexcloud (when they
are not using apache.beam or other libraries that limit grpcio to
< 1.68.1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants