Skip to content

Conversation

@Pei-Cheng-Yu
Copy link
Contributor

Related issues

Related: #53051

WHY

according to discussion in PR #56920
implement the search / pattern match counterpart filers in the backend for pool, queue, operator


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels Oct 30, 2025
Copy link
Member

@jason810496 jason810496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! LGMT overall.

Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to have this but "danger zone", the columns you add to be filtered is not having an index, so if this is the only part you are searching for and you have a large DB then this is triggering a full table scan and can be used as DOS as well as will have poor response time.

@jason810496
Copy link
Member

Nice to have this but "danger zone", the columns you add to be filtered is not having an index, so if this is the only part you are searching for and you have a large DB then this is triggering a full table scan and can be used as DOS as well as will have poor response time.

Good point!
We are resolving N+1 problems recently and maybe checking whether there are indexes for all the filters will be next stage of API performance optimization.

Copy link
Member

@jason810496 jason810496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@pierrejeambrun pierrejeambrun added this to the Airflow 3.2.0 milestone Nov 4, 2025
@pierrejeambrun pierrejeambrun merged commit 45678e8 into apache:main Nov 4, 2025
115 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Nov 4, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants