Enable ruff PLW0602 rule #57588
Merged
Enable ruff PLW0602 rule #57588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscheffl
requested review from
amoghrajesh,
ashb,
bugraoz93,
eladkal,
ephraimbuddy,
gopidesupavan,
jason810496,
jedcunningham,
kaxil,
pierrejeambrun,
potiuk,
rawwar and
shubhamraj-git
as code owners
boring-cyborg
bot
added
area:API
jason810496
approved these changes
Oct 31, 2025
Lee-W
approved these changes
Oct 31, 2025
amoghrajesh
approved these changes
Oct 31, 2025
jscheffl
force-pushed
the
feature/add-ruff-plw0602-rule
branch
from
768cc85 to
68f9b50
Compare
Backport failed to create: v3-1-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker d52c4fb v3-1-testThis should apply the commit to the v3-1-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
jscheffl
added a commit
to jscheffl/airflow
that referenced
this pull request
Oct 31, 2025
(cherry picked from commit d52c4fb)
jscheffl
added a commit
to jscheffl/airflow
that referenced
this pull request
Oct 31, 2025
(cherry picked from commit d52c4fb) Co-authored-by: Jens Scheffler <[email protected]>
jscheffl
added a commit
that referenced
this pull request
Oct 31, 2025
* Enable ruff PLW0602 rule (#57588) (cherry picked from commit d52c4fb) * Enable ruff PLW0129 rule (#57516) * Enable ruff PLW0129 rule * Fix pytests * Fix pytests as working in logs changed * Fix pytests as working in logs changed * [v3-1-test] Enable ruff PLW0602 rule (#57588) (cherry picked from commit d52c4fb) Co-authored-by: Jens Scheffler <[email protected]>
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 3, 2025
* Enable ruff PLW0602 rule (#57588) (cherry picked from commit d52c4fb) * Enable ruff PLW0129 rule (#57516) * Enable ruff PLW0129 rule * Fix pytests * Fix pytests as working in logs changed * Fix pytests as working in logs changed * [v3-1-test] Enable ruff PLW0602 rule (#57588) (cherry picked from commit d52c4fb) Co-authored-by: Jens Scheffler <[email protected]>
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 4, 2025
* Enable ruff PLW0602 rule (#57588) (cherry picked from commit d52c4fb) * Enable ruff PLW0129 rule (#57516) * Enable ruff PLW0129 rule * Fix pytests * Fix pytests as working in logs changed * Fix pytests as working in logs changed * [v3-1-test] Enable ruff PLW0602 rule (#57588) (cherry picked from commit d52c4fb) Co-authored-by: Jens Scheffler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While implementing #57294 I realized that a couple of more ruff PLW rules might be interesting, this PR enables PLW0211
Alongside saw that PLW0245 and PLW0406 needed no fixes and enabled them as well
See also https://docs.astral.sh/ruff/rules/#warning-plw