Fix executor field not populated for tasks without explicit executor #57590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
force-pushed
the
ensure-executor-exists
branch
from
45591e5 to
2b918e7
Compare
kaxil
requested review from
bbovenzi,
pierrejeambrun,
ryanahamilton and
shubhamraj-git
as code owners
kaxil
force-pushed
the
ensure-executor-exists
branch
from
2b918e7 to
c7be733
Compare
dheerajturaga
approved these changes
Oct 31, 2025
When a task doesn't specify an executor, the executor field in the database remained `NULL`, causing it to not display in the UI. This fix resolves the executor to the default configured executor name at task instance creation and refresh time, following the same pattern as other fields like pool and queue. The fix modifies TaskInstance.insert_mapping() and TaskInstance.refresh_from_task() to automatically populate the executor field with the default executor when task.executor is None, ensuring the field always displays correctly in the UI. closes apache#57526
kaxil
force-pushed
the
ensure-executor-exists
branch
from
c7be733 to
e7b5533
Compare
jscheffl
approved these changes
Oct 31, 2025
|
|
||
| executor = task.executor | ||
| if executor is None: | ||
| executor_name = ExecutorLoader.get_default_executor_name() |
There was a problem hiding this comment.
As we call on task instance potentially often and there is a bunch of logic behind this - but w/o DB access - to wire up executor details... should the called get_default_executor_name() method being implement the @cache decorator?
There was a problem hiding this comment.
@jscheffl, would this return the right executor in a multi executor context?
There was a problem hiding this comment.
If the executor field is None then the default executor is used during execution - so the logic on API for display is consistent here. If the field on the TaskInstance is filled, then it references to the executor that specifically is wanted.
eladkal
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a task doesn't specify an executor, the executor field in the database remained
NULL, causing it to not display in the UI. This fix resolves the executor to the default configured executor name at task instance creation and refresh time, following the same pattern as other fields like pool and queue.The fix modifies TaskInstance.insert_mapping() and TaskInstance.refresh_from_task() to automatically populate the executor field with the default executor when task.executor is None, ensuring the field always displays correctly in the UI.
closes #57526
Same screenshots as #57526 :)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.