Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the optional dependencies #138

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update the optional dependencies #138

wants to merge 3 commits into from

Conversation

twogee
Copy link
Contributor

@twogee twogee commented Oct 4, 2020

No description provided.

@twogee twogee force-pushed the fresh-dependencies branch 2 times, most recently from de1d02f to 1ee6231 Compare March 6, 2021 19:19
@bodewig
Copy link
Member

bodewig commented Sep 26, 2021

@twogee the switch to jakarta.mail is not backwards compatible. I don't think we can do it that way at all. Rather we'll need to introduce a new type of Mailer and an additional jar with different dependencies, I'm afraid.

@bodewig
Copy link
Member

bodewig commented Oct 2, 2021

Thank you @twogee - do you think you could split the Jakarta Mailer support changes from the other changes?

The changes to ClasspathUtils seem to be completely unrelated to either and the chunk that removes string concatenation is completely unnecessary anyway.

@twogee
Copy link
Contributor Author

twogee commented Oct 2, 2021

Thanks, @bodewig, and sorry about missing the extraneous changes.
I will open a new PR for changes re Jakarta Mail specifically.
The change to ClasspathUtils is related to an attempt to avoid nested try in EmailTask#getMailerImplementation().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twogee @bodewig