Skip to content

fix:chown socket file to belong to nobody #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix:chown socket file to belong to nobody #54

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ffd5a4
fix:chown socket file to belong to nobody
zar3bski Sep 15, 2022
40c8aae
test:mock os chown and getpwnam
zar3bski Sep 16, 2022
93c228a
feat: socket owner can be explicitly set in conf
zar3bski Sep 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions apisix/runner/server/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,11 @@
# limitations under the License.
#

import grp
import os
import socket

from pwd import getpwnam
from threading import Thread as NewThread
from apisix.runner.server.handle import Handle as NewServerHandle
from apisix.runner.server.protocol import Protocol as NewServerProtocol
Expand Down Expand Up @@ -82,6 +84,7 @@ def __init__(self, config: NewServerConfig):
os.remove(self.fd)
self.sock = socket.socket(socket.AF_UNIX, socket.SOCK_STREAM)
self.sock.bind(self.fd)
os.chown(self.fd, getpwnam('nobody').pw_uid, grp.getgrnam('nobody').gr_gid)
self.sock.listen(1024)

self.logger = NewServerLogger(config.logging.level)
Expand Down