Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: script distribute and run #1982

Merged
merged 15 commits into from
Aug 5, 2020
Merged

feat: script distribute and run #1982

merged 15 commits into from
Aug 5, 2020

Conversation

nic-chen
Copy link
Member

@nic-chen nic-chen commented Aug 3, 2020 •
edited by membphis
Loading

What this PR does / why we need it:

support script distribute and run that can do a lot, such as orchestrating plugins

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible?

@nic-chen nic-chen closed this Aug 3, 2020
@nic-chen nic-chen reopened this Aug 3, 2020
@nic-chen nic-chen changed the title feat: script distribute and run [WIP]feat: script distribute and run Aug 3, 2020
membphis
membphis requested changes Aug 4, 2020
View reviewed changes
@membphis membphis changed the title [WIP]feat: script distribute and run feat: script distribute and run Aug 4, 2020
@membphis
Copy link
Member

membphis commented Aug 4, 2020

@nic-chen I think you can write some doc now.

@nic-chen
Copy link
Member Author

nic-chen commented Aug 4, 2020

@nic-chen I think you can write some doc now.

done.

membphis
membphis requested changes Aug 4, 2020
View reviewed changes
Copy link
Member

@membphis membphis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to add a test case: enable "plugins" and "scripts" at the same time.

We should throw an error and not allow them to work together.

@nic-chen
Copy link
Member Author

nic-chen commented Aug 5, 2020

I think we need to add a test case: enable "plugins" and "scripts" at the same time.

We should throw an error and not allow them to work together.

done.

membphis
membphis requested changes Aug 5, 2020
View reviewed changes
membphis
membphis reviewed Aug 5, 2020
View reviewed changes
@membphis membphis mentioned this pull request Aug 5, 2020
Open
@membphis membphis merged commit 65df727 into apache:master Aug 5, 2020
@nic-chen nic-chen deleted the script branch March 24, 2022 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@membphis membphis membphis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nic-chen @membphis @johzchen