fix(java/driver/flightsql): Have InfoMetadataBuilder in a try-with-re…

…sources block to prevent VectorSchemaRoot leak
apache · Sep 14, 2023 · 5cd8579 · 5cd8579
1 parent 34b364f
commit 5cd8579
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/.../flight-sql/src/main/java/org/apache/arrow/adbc/driver/flightsql/FlightSqlConnection.java b/.../flight-sql/src/main/java/org/apache/arrow/adbc/driver/flightsql/FlightSqlConnection.java
@@ -109,9 +109,11 @@ public AdbcStatement bulkIngest(String targetTableName, BulkIngestMode mode)
 
   @Override
   public ArrowReader getInfo(int[] infoCodes) throws AdbcException {
-    try (final VectorSchemaRoot root =
-        new InfoMetadataBuilder(allocator, client, infoCodes).build()) {
+    try (InfoMetadataBuilder builder = new InfoMetadataBuilder(allocator, client, infoCodes)) {
+      final VectorSchemaRoot root = builder.build();
       return RootArrowReader.fromRoot(allocator, root);
+    } catch (Exception e) {
+      throw AdbcException.invalidState("[Flight SQL] Failed to get info");
     }
   }