fix(go/adbc/driver/snowflake): Make SHOW WAREHOUSES test less flaky #1494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joellubi
changed the title
soumyadsanyal
pushed a commit
to soumyadsanyal/arrow-adbc
that referenced
this pull request
Jan 31, 2024
…pache#1494) Minor fix to a test that has been breaking each time Snowflake added a new field to the result of a `SHOW WAREHOUSES` query. Previously we asserted the number of columns, but this number has been changing. Instead of completely removing this part of the test, we can assert the columns we know currently should be present and expect that Snowflake won't make breaking changes to the schema by removing columns. The specific contents of the schema are not relevant to the original purpose of the test anyway, so it should be fine if the actual schema continues to grow beyond what is asserted here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor fix to a test that has been breaking each time Snowflake added a new field to the result of a
SHOW WAREHOUSESquery.Previously we asserted the number of columns, but this number has been changing. Instead of completely removing this part of the test, we can assert the columns we know currently should be present and expect that Snowflake won't make breaking changes to the schema by removing columns. The specific contents of the schema are not relevant to the original purpose of the test anyway, so it should be fine if the actual schema continues to grow beyond what is asserted here.