fix(python/adbc_driver_manager): return 'real' reader in fetch_record_batch #1530
+14
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_batch We wrap RecordBatchReader to try to provide extra error metadata from ADBC when using this API. But PyArrow may try to extract the underlying C++ arrow::RecordBatch pointer from the reader, which won't exist in our wrapped reader. For the public API, return the unwrapped reader instead. Fixes apache#1523.
jorisvandenbossche
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We wrap RecordBatchReader to try to provide extra error metadata from ADBC when using this API. But PyArrow may try to extract the underlying C++ arrow::RecordBatch pointer from the reader, which won't exist in our wrapped reader. For the public API, return the unwrapped reader instead.
Fixes #1523.