-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(c/driver): fix clang-tidy warnings #1928
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for taking a few days to get back here!
I think the actual errors might be solved by ensuring that the correct standard library is installed? I see that the first google result here is one of your blog posts, but perhaps the symlink fix isn't working anymore (or is still picking up the wrong -std
library?)
It doesn't look like it's that easy to ignore directories, but the "right" way to do it might be to run |
Yeah, I was trying to figure out how to just ignore Nanoarrow. I suppose we could invoke
D'oh... |
I gave it a try but I'm having the same issue locally with the standard library (C seems to work but not C++)! I started apache/arrow-nanoarrow#538 and will poke away at it (clang-tidy is awesome and caught quite a few things). |
Fixes #1927.