fix(go/adbc/driver/snowflake): call GetObjects with null catalog at catalog depth #2194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zeroshade or @joellubi - can this be merged? |
joellubi
reviewed
Oct 2, 2024
| sql.Named("PK_QUERY_ID", pkQueryID), | ||
| sql.Named("FK_QUERY_ID", fkQueryID), | ||
| sql.Named("UNIQUE_QUERY_ID", uniqueQueryID), | ||
| sql.Named("TERSE_QUERY_ID", terseDbQueryID), |
There was a problem hiding this comment.
I'm not sure TERSE is the most relevant name for this query parameter. Perhaps SHOW_DB_QUERY_ID (or SHOW_TERSE_DB_QUERY_ID if you want to be more explicit), since TERSE just limits the output columns and can be used with other commands.
joellubi
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partially addresses #2171 by calling SHOW TERSE DATABASES if GetObjects is called with the catalog depth and a null catalog is passed.
It does not address other parts of #2171 where a catalog can be null at other depths.