Skip to content

GH-848: TypedValue should be treated as Nullable in bind function in AvaticaParameterBinder #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

GH-848: TypedValue should be treated as Nullable in bind function in AvaticaParameterBinder #849

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ...ql-jdbc-core/src/main/java/org/apache/arrow/driver/jdbc/utils/AvaticaParameterBinder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
import org.apache.arrow.vector.VectorSchemaRoot;
import org.apache.arrow.vector.types.pojo.ArrowType;
import org.apache.calcite.avatica.remote.TypedValue;
import org.checkerframework.checker.nullness.qual.Nullable;

/**
* Convert Avatica PreparedStatement parameters from a list of TypedValue to Arrow and bind them to
Expand Down Expand Up @@ -108,9 +109,9 @@ public void bind(List<TypedValue> typedValues, int index) {
* @param typedValue TypedValue to bind to the vector.
* @param index Vector index to bind the value at.
*/
private void bind(FieldVector vector, TypedValue typedValue, int index) {
private void bind(FieldVector vector, @Nullable TypedValue typedValue, int index) {
try {
if (typedValue.value == null) {
if (typedValue == null || typedValue.value == null) {
if (vector.getField().isNullable()) {
vector.setNull(index);
} else {
Expand All @@ -127,7 +128,7 @@ private void bind(FieldVector vector, TypedValue typedValue, int index) {
throw new UnsupportedOperationException(
String.format(
"Binding value of type %s is not yet supported for expected Arrow type %s",
typedValue.type, vector.getField().getType()));
typedValue == null ? "null" : typedValue.type, vector.getField().getType()));
}
}

Expand Down