Avro writer prefix support #8371
Open
+382
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…additional types like Decimal, FixedSizeBinary, Utf8, List, Struct, and Map. Add round-trip validation for complex and logical types including Duration and UUID.
Co-authored-by: Connor Sanders <[email protected]>
…y code structure.
github-actions
bot
added
arrow
…iter - Introduced `FingerprintStrategy` enum to customize fingerprinting methods, including Rabin, ConfluentSchemaId, MD5, and SHA256. - Updated stream writer to handle per-record prefix generation based on the selected strategy. - Added related unit tests for configurable fingerprint strategies.
jecsand838
reviewed
Sep 18, 2025
There was a problem hiding this comment.
@nathaniel-d-ef Thanks for getting this draft up! It looks really good overall, I just had a few suggestions.
|
Thank you for the thorough review and recommendations @jecsand838 - I've refined the approach and this is now in a much better place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
This introduces writer-side fingerprint prefix support, removing the existing hard-coded Rabin approach with a configurable pattern extending off of the work done on the reader side. In addition to supporting the SHA256 and MD5 (feature flagged), we also cover compatibility with Confluent's wire format IDs.
What changes are included in this PR?
FingerprintAlgorithmin schema and writer.Are these changes tested?
Yes, existing tests are all passing, and tests have been added to validate the prefix outputs. Benchmark results show no appreciable changes.
Are there any user-facing changes?