Use Arc<FileEncryptionProperties> everywhere to be be consistent with FileDecryptionProperties
#8626
+13
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ryptionProperties`
alamb
commented
Oct 15, 2025
| /// Build the encryption properties | ||
| pub fn build(self) -> Result<FileEncryptionProperties> { | ||
| Ok(FileEncryptionProperties { | ||
| pub fn build(self) -> Result<Arc<FileEncryptionProperties>> { |
There was a problem hiding this comment.
this is the main API change, and the rest of the changes mostly follow from here
| path: &str, | ||
| decryption_properties: Arc<FileDecryptionProperties>, | ||
| encryption_properties: FileEncryptionProperties, | ||
| encryption_properties: Arc<FileEncryptionProperties>, |
There was a problem hiding this comment.
this is now nicely symmetric which I think is a good sign
mbrobbel
approved these changes
Oct 15, 2025
|
You are a reviewing machine @mbrobbel -- thank you 🙏 |
|
FYI @adamreeve and @rok |
etseidl
approved these changes
Oct 15, 2025
adamreeve
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
57.0.0(October 2025) #7835Arc<FileDecryptionProperties>to reduce size of ParquetMetadata and avoid copying whenencryptionis enabled #8470Rationale for this change
While testing arrow 57 with DataFusion, I found there was a disconnect
in the builders that the
FileDecryptionPropertiesbuilder builds Arc and theFileEncryptionPropertiesbuilder builds the struct directlyLet's make the APIs consistent
This also allows encryption properties to be shared and cloned cheaply (I am not sure how often this is needed, but it seems like a reasonable thing to do)
What changes are included in this PR?
See above
Are these changes tested?
Yes, by existing tests
Are there any user-facing changes?
This is an API change, started in #8470