Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C#] Proper spot to include flight sql nuget package for release? #38694

Closed
jeremyosterhoudt opened this issue Nov 13, 2023 · 3 comments
Closed

[C#] Proper spot to include flight sql nuget package for release? #38694

jeremyosterhoudt opened this issue Nov 13, 2023 · 3 comments
Assignees
@kou
Labels
Component: C# Type: usage Issue is a user question
Milestone
20.0.0

Comments

@jeremyosterhoudt
Copy link
Contributor

Describe the usage question you have. Please include as many useful details as possible.

I noticed Flight SQL for C# was not in the latest 14.x release. It occurred to me that when I did the PR to add support I never updated any scripts for releasing the package. The scripts for release have a lot of different sections. Would this be the correct place to add the new project for nuget release https://github.com/apache/arrow/blob/main/dev/release/post-06-csharp.sh#L38-L42? Are there any additional areas that may need to be edited?

Component(s)

C#
@jeremyosterhoudt jeremyosterhoudt added the Type: usage Issue is a user question label Nov 13, 2023
@jeremyosterhoudt jeremyosterhoudt changed the title [C#] Proper spot to include flight sql nuget package release [C#] Proper spot to include flight sql nuget package for release Nov 13, 2023
@jeremyosterhoudt jeremyosterhoudt changed the title [C#] Proper spot to include flight sql nuget package for release [C#] Proper spot to include flight sql nuget package for release? Nov 14, 2023
@CurtHagenlocher
Copy link
Contributor

I don't know the answer :). But if you look at commit 6776229, you'll see the package added to both that file and to dev/tasks/tasks.yml.

@ndglover
Copy link
Contributor

Hi @jeremyosterhoudt - I'm looking at using Flight SQL to query dremio from a .net service. It looks like you addedsome functionality in this space. I don't see a FlightSQLClient or a released nuget package though. Just wondering if you have any insights around this? Is this repo actively maintained because it seems like there are many outstanding PR's like this one.

If there is a better place to discuss these things please point me towards it.

Thanks in advance

@adamreeve adamreeve mentioned this issue Jan 20, 2025
Closed
kou added a commit to kou/arrow that referenced this issue Jan 20, 2025
@kou
apacheGH-38694: [Release][C#] Release Apache.Arrow.Flight.Sql
8d7b2ca
@github-actions github-actions bot mentioned this issue Jan 20, 2025
Merged
kou added a commit that referenced this issue Jan 21, 2025
@kou
GH-38694: [Release][C#] Release Apache.Arrow.Flight.Sql (#45309)
2d76789 
### Rationale for this change

Apache.Arrow.Flight.Sql should be relased too.

### What changes are included in this PR?

Upload it.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* GitHub Issue: #38694

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@kou
Copy link
Member

kou commented Jan 21, 2025

Issue resolved by pull request 45309
#45309

@kou kou added this to the 20.0.0 milestone Jan 21, 2025
@kou kou closed this as completed Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: C# Type: usage Issue is a user question
Projects
None yet
Milestone
20.0.0
Development

No branches or pull requests
4 participants
@kou @CurtHagenlocher @ndglover @jeremyosterhoudt