Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-45787: [Integration][CI] Remove pin for Rust 1.77 on conda integration tests #45790

Merged
merged 1 commit into from
Mar 16, 2025

Conversation

raulcd
Copy link
Member

@raulcd raulcd commented Mar 14, 2025

Rationale for this change

Our integration jobs are failing due to an old version of rustc being used.

What changes are included in this PR?

Remove current pin for rust to 1.77

Are these changes tested?

The currently failing CI job is now successful

Are there any user-facing changes?

This image might be used on other repositories (nanoarrow, arrow-rust, arrow-go, arrow-java, ...). It might also affect those?

Copy link

⚠️ GitHub issue #45787 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Mar 14, 2025
@raulcd
Copy link
Member Author

raulcd commented Mar 14, 2025

@github-actions crossbow submit verify-rc-source-integration-*

Copy link

Revision: 675eed6

Submitted crossbow builds: ursacomputing/crossbow @ actions-b58556064a

Task Status
verify-rc-source-integration-linux-almalinux-8-amd64 GitHub Actions
verify-rc-source-integration-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-integration-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-integration-linux-ubuntu-24.04-amd64 GitHub Actions
verify-rc-source-integration-macos-amd64 GitHub Actions
verify-rc-source-integration-macos-arm64 GitHub Actions
verify-rc-source-integration-macos-conda-amd64 GitHub Actions

@raulcd raulcd marked this pull request as ready for review March 14, 2025 13:14
@raulcd
Copy link
Member Author

raulcd commented Mar 14, 2025

@paleolimbot you seemed to be the one that pinned that version. Is there something else I should check?

@paleolimbot
Copy link
Member

Nope...thanks! I'll remove the corresponding version pin in arrow-rs and arrow-nanoarrow as well 🙂

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @raulcd

I double checked and indeed the CI test is green and rust is building successfully

https://github.com/apache/arrow/actions/runs/13856484485/job/38774360335?pr=45790

name: stable-x86_64-unknown-linux-gnu
  active because: it's the default toolchain
  installed targets:
    x86_64-unknown-linux-gnu
  + pushd /arrow/rust
  /arrow/rust /
  + cargo build -p arrow-integration-testing --target-dir /build/rust
      Updating crates.io index
       Locking 370 packages to latest compatible versions
        Adding bincode v1.3.3 (available: v2.0.1)
        Adding flatbuffers v24.12.23 (available: v25.2.10)
        Adding object_store v0.11.2 (available: v0.12.0)
        Adding pyo3 v0.23.5 (available: v0.24.0)
        Adding rand v0.8.5 (available: v0.9.0)
        Adding twox-hash v1.6.3 (available: v2.1.0)
   Downloading crates ...

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Mar 14, 2025
@alamb
Copy link
Contributor

alamb commented Mar 14, 2025

Nope...thanks! I'll remove the corresponding version pin in arrow-rs and arrow-nanoarrow as well 🙂

I filed a ticket and PR for this issue in arrow-rs:

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Can we use this instead of #45801? I think that no pin is better.

@alamb
Copy link
Contributor

alamb commented Mar 15, 2025

+1

Can we use this instead of #45801? I think that no pin is better.

yes I agree this PR is better. I closed #45801. Thank you @kou

@kou
Copy link
Member

kou commented Mar 16, 2025

Thanks. I'll merge this.

@kou kou merged commit b957769 into apache:main Mar 16, 2025
36 checks passed
@kou kou removed the awaiting merge Awaiting merge label Mar 16, 2025
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit b957769.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants