-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-45807: [C++] compatibility patches for protobuf 30 #45805
base: main
Are you sure you want to change the base?
Conversation
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format?
or
See also: |
f8fbc5c
to
6e87552
Compare
6e87552
to
9ac71b6
Compare
Thanks for the contribution, this is not a minor PR though. I will create and link an issue for you! |
|
Could you apply this diff to fix the format: https://github.com/apache/arrow/actions/runs/13872657236/job/38822487820?pr=45805#step:6:33 |
6a06ed1
to
eff85c8
Compare
Thanks for creating the issue, I have added the reference to it in the latest version of the commit an applied the formatting changes 🤗 Edit: Argh, created a whitespace issue with my editor, now applied it with |
This version of protobuf has switched a few interface types from `std::string` to `std::string_view` and therefore introcuces some breaking changes in the code. Fix these by applying appropriate casts. Link: https://protobuf.dev/support/migration/#v30 Signed-off-by: Christian Heusel <[email protected]>
eff85c8
to
6994dac
Compare
@github-actions crossbow submit -g cpp |
Revision: 6994dac Submitted crossbow builds: ursacomputing/crossbow @ actions-4471dd3b4d |
Rationale for this change
The current version of arrow is not compatible with protobuf 30.0 and beyond, which we are currently rolling out in Arch Linux:
https://archlinux.org/todo/protobuf-300/
What changes are included in this PR?
In order to migrate to the new APIs based on
std::string_view
we just use a few casts tostd::string
.Are these changes tested?
Compile tested only, but there are no problems expected.