GH-46085: [C++][FS][Azure] Treat a 403 when getting container properties like the container exists #46095
+19
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jabbera
changed the title
|
|
|
Failures seem related to: #46077, not this change. |
|
Any chance of getting this looked at? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
User delegated sas tokens in Azure (and some standard sas tokens) don't have permissions to query container properties. The assumption needs to be made that the container exists and let something further up the chain fail if the container doesn't exist.
There is functionality that creates a new container, but it won't come into play because the sas token also does not have permission to do that either.
What changes are included in this PR?
Return an fs item type of directory with a modified time of now when getting container properties returns a 403.
Are these changes tested?
Yes, manually. Unsure how to integrate into automated test suite. Happy to discuss.
Are there any user-facing changes?
No