[C++][Acero] Asofjoin respect PauseProducing from downstream. #46140
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Current implementation of asof join does not respect backpressure from downstream nodes. PauseProducing implementation is empty. This leads to unbound memory consumption with slow sinks.
What changes are included in this PR?
With this change PauseProducing causes ProcessThread to pause when backpressure is applied. Pause logic stolen from source_node and seems to work.
Inputs do not require additional handling sice each input has its own backpressure queue.
Are these changes tested?
Tested in my application. Still deciding how to test it. Either by checking memory consumption or by checking whether the pause is propagating upstream? The latter seems easier.
Are there any user-facing changes?
No
PS
Also I did not modify the single threaded version. Can someone using it chime in?