Skip to content

Conversation

@chiranmoyf
Copy link

Rationale for this change

For aarch64 machines none of the existing options were valid except NONE. With the DEFAULT option in simd_level Neon paths will be activated for aarch64 machines.

What changes are included in this PR?

Adding DEFAULT option in simd_level of /dev/archery/archery/cli.py

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

For aarch64 machines none of the existing options were valid except NONE. With the DEFAULT option in simd_level Neon paths will be activated for aarch64 machines.
@github-actions
Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@github-actions github-actions bot added the awaiting review Awaiting review label Nov 27, 2025
@chiranmoyf chiranmoyf changed the title Adding DEFAULT option in simd_level of cli.py MINOR: [Python] Adds DEFAULT option in simd_level of cli.py Nov 27, 2025
Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi thanks for the PR.
This does not fit our definition of MINOR as we only allow minor PRs with small grammar or documentation changes. Could you open an issue?
Can you expand on how were you using, I am curious on the archery build usage.
DEFAULT is also the default value if you don't pass any simd_level.

@chiranmoyf
Copy link
Author

Hi thanks for the PR. This does not fit our definition of MINOR as we only allow minor PRs with small grammar or documentation changes. Could you open an issue? Can you expand on how were you using, I am curious on the archery build usage. DEFAULT is also the default value if you don't pass any simd_level.

Sure, @raulcd we'll raise an issue.
Yes, DEFAULT is the default value if nothing is passed, but since it is missing in the simd_level list, DEFAULT is treated as an invalid argument.

Here's the exact error message.
Error: Invalid value for '--simd-level': 'DEFAULT' is not one of 'NONE', 'SSE4_2', 'AVX2', 'AVX512'.

@raulcd
Copy link
Member

raulcd commented Nov 28, 2025

Thanks for the answer. My question about the usage is because we do not use the archery build command for Arrow's CI or on the codebase. It is not on documentation either. It seems the last reference to using it was around 6-7 years ago. I was curious on how are you using it as I don't think it's currently actively maintained.

@chiranmoyf
Copy link
Author

We followed this documentation to build and benchmark Arrow using Archery.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review Awaiting review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants