Build website through Github Actions #3092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
commented
Aug 13, 2024
| @@ -43,7 +43,7 @@ <h1>{{ .Title }}</h1> | |||
| {{ partial "feedback.html" .Site.Params.ui.feedback }} | |||
| <br /> | |||
| {{ end }} | |||
| {{ if (.Site.DisqusShortname) }} | |||
| {{ if (.Site.Config.Services.Disqus.Shortname) }} | |||
There was a problem hiding this comment.
ERROR deprecated: .Site.DisqusShortname was deprecated in Hugo v0.120.0 and will be removed in Hugo 0.133.0. Use .Site.Config.Services.Disqus.Shortname instead.
martin-g
reviewed
Aug 13, 2024
Fokko
force-pushed
the
fd-fix-site
branch
23 times, most recently
from
d7f7e1d
to
d800cf9
Compare
Fokko
force-pushed
the
fd-fix-site
branch
13 times, most recently
from
206e8c8
to
5603d90
Compare
Fokko
commented
Aug 14, 2024
| @@ -1,5 +1,4 @@ | |||
| public/ | |||
| resources/ | |||
| node_modules/ | |||
| package-lock.json | |||
There was a problem hiding this comment.
We actually want to track the versions to use in npm ci
Fokko
force-pushed
the
fd-fix-site
branch
2 times, most recently
from
4ac2f1b
to
cebefc2
Compare
martin-g
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the 1.12.0 release, I noticed that there are no steps on how to update the new website. This is an attempt to build everything through a Github Action and also adds instructions.
What is the purpose of the change
(For example: This pull request improves file read performance by buffering data, fixing AVRO-XXXX.)
Verifying this change
(Please pick one of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation