Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVRO-4038: [C++] Add local-timestamp-nanos and timestamp-nanos #3102

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

glywk
Copy link
Contributor

@glywk glywk commented Aug 17, 2024

AVRO-4038

What is the purpose of the change

This pull request adds support of the following logical types as defined since specification 1.12.0:

  • timestamp-nanos
  • local-timestamp-nanos

Verifying this change

This change added tests and can be verified as follows:

  • Extended interop tests to verify consistent valid schema names between SDKs

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@glywk glywk changed the title AVRO-3884: [C++] Add local-timestamp-nanos and timestamp-nanos AVRO-4038: [C++] Add local-timestamp-nanos and timestamp-nanos Aug 18, 2024
@martin-g
Copy link
Member

The merge of #3053 caused merge conflicts ...

@glywk
Copy link
Contributor Author

glywk commented Aug 19, 2024

The merge of #3053 caused merge conflicts ...

Conflicts are resolved.
Regards

Copied from the example at https://github.com/actions/labeler?tab=readme-ov-file#outputs
Trying to fix https://github.com/apache/avro/actions/runs/10460767435/job/28981928566?pr=3102
```
Run actions/labeler@v5
  with:
    repo-token: ***
    sync-labels: true
    configuration-path: .github/labeler.yml
    dot: true
The configuration file (path: .github/labeler.yml) was not found locally, fetching via the api
Warning: The action requires write permission to add labels to pull requests. For more information please refer to the action documentation: https://github.com/actions/labeler#permissions
Error: Resource not accessible by integration
```

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
@github-actions github-actions bot added C++ Pull Requests for C++ binding build labels Aug 21, 2024
@martin-g martin-g merged commit 885c62d into apache:main Aug 21, 2024
4 checks passed
@glywk glywk deleted the cpp_times_nanos branch September 3, 2024 06:58
@glywk glywk restored the cpp_times_nanos branch September 3, 2024 06:59
@glywk glywk deleted the cpp_times_nanos branch September 3, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build C++ Pull Requests for C++ binding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants