AVRO-4040: [java] @AvroInternal annotation for getSchema() and getSpecificData() methods #3124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgalek
changed the title
|
I've fixed spotless error, so build should pass now ;) |
|
https://github.com/bgalek/avro/actions/runs/10610238789/job/29407344572 it passed on my org ;) |
aleksandrserbin
approved these changes
Sep 2, 2024
opwvhk
approved these changes
Sep 5, 2024
opwvhk
reviewed
Sep 5, 2024
lang/java/avro/src/main/java/org/apache/avro/specific/AvroInternal.java
Outdated
Show resolved
Hide resolved
…fic/AvroInternal.java Co-authored-by: Oscar Westra van Holthe - Kind <[email protected]>
|
Any chances for merge? :) |
|
@opwvhk hi, do we have any ETA for this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request introduces
@AvroInternalannotation interface that serves only to identify the semantics of being something internal/avro specific.Thanks to this indicator annotation, class processors can ignore those avro-specific fields not coming from user defined schema.
Fixes https://issues.apache.org/jira/browse/AVRO-4040
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation
I think we could mention this interface in some docs.