Skip to content

fix(setup.py): improve requirements parsing and require setuptools>=80.9.0 for Python 3.12 compatibility #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BorisQuanLi wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(setup.py): improve requirements parsing and require setuptools>=80.9.0 for Python 3.12 compatibility #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b0daf96
fix: improve setup.py for Python 3.12 compatibility
BorisQuanLi Jul 13, 2025
4357952
docs: align README with setup.py modernization
BorisQuanLi Jul 13, 2025
71ae133
fix(setup.py): require setuptools>=80.9.0 for Python 3.12 compatibility
BorisQuanLi Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ so any changes or install dependencies are self-contained.

As a one time setup, let's install the project's dependencies from the [`requirements.txt`](requirements.txt) file.

```py
```sh
# It's always a good idea to update pip before installing dependencies.
pip install -U pip

Expand Down
9 changes: 5 additions & 4 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,15 @@
from setuptools import setup, find_packages

with open("requirements.txt") as f:
requirements = f.readlines()
requirements = [line.strip() for line in f.readlines() if line.strip() and not line.startswith('#')]

setup(
name="My app",
version="1.0",
name="my-app",
version="1.0.0",
description="Python Apache Beam pipeline.",
author="My name",
author_email="[email protected]",
packages=find_packages(),
install_requires=requirements,
install_requires=requirements + ["setuptools>=80.9.0"],
python_requires=">=3.8",
)