Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when creating pipeline without specifying options #24842

Closed
wants to merge 1 commit into from

Conversation

yyy1000
Copy link
Contributor

@yyy1000 yyy1000 commented Dec 30, 2022

Fix #issue18699. Now the LOG will warn when creating pipeline without specifying options.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@github-actions github-actions bot added the java label Dec 30, 2022
@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @apilloud for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Abacn
Copy link
Contributor

Abacn commented Dec 30, 2022

Thanks for the interests. However, the create() method without argument will take command line arguments as pipeline options. #18699 is talking about when there is no option found, either after command line is parsed or use create(PipelineOption) with an empty PipelineOption.

@yyy1000
Copy link
Contributor Author

yyy1000 commented Dec 31, 2022

Got it!
I will continue to inspect it carefully.
BTW, could you please help me to review these issues and PR?
I submitted them some days ago but no one reply.
Thanks!
#issue24785 and the PR [#24773 ]

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2023

Reminder, please take a look at this pr: @apilloud

@yyy1000 yyy1000 closed this Jan 7, 2023
@yyy1000 yyy1000 deleted the java-pipeline branch February 17, 2023 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It should be an error to run a Pipeline without ever specifying options
2 participants