Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ProtoCoder NoSuchMethodException #34194

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Suvrat1629
Copy link

Please add a meaningful description for your change here

Handles NoSuchMethodException in ProtoCoder.getParser() when getDefaultInstance() is unavailable by adding a fallback to instantiation.
Addresses #19713

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

github-actions bot commented Mar 6, 2025

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Suvrat1629
Copy link
Author

@damccorm Could you please take a look as this is for issue #19713

@damccorm
Copy link
Contributor

damccorm commented Mar 7, 2025

Thanks for looking into this issue

@damccorm Could you please take a look as this is for issue #19713

It looks like Yi got assigned this PR by the bot, it is usually better to allow the bot to assign reviewers so that reviews are balanced.

@Suvrat1629
Copy link
Author

@damccorm Oh ok I did not know the bot worked that way, I asked you for a review because you had opened the issue this pr was addressing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants