Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Removed < 1.66 for grpcio #34196

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
+12 −2
Open

[DO NOT MERGE] Removed < 1.66 for grpcio #34196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
86722c6
Removed < 1.66 for grpcio
liferoad Mar 6, 2025
a5d6560
Update sdks/python/setup.py
liferoad Mar 7, 2025
4cc9433
updated the version upper bound
liferoad Mar 8, 2025
d6fd6fa
skip pip check for lint
liferoad Mar 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions sdks/python/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,8 +354,12 @@ def get_portability_package_data():
'cloudpickle~=2.2.1',
'fastavro>=0.23.6,<2',
'fasteners>=0.3,<1.0',
# TODO(https://github.com/grpc/grpc/issues/37710): Unpin grpc
'grpcio>=1.33.1,<2,!=1.48.0,!=1.59.*,!=1.60.*,!=1.61.*,!=1.62.0,!=1.62.1,<1.66.0', # pylint: disable=line-too-long
# NOTE(https://github.com/grpc/grpc/issues/37710):
# Some grpc 1.66.0+ versions have a regression,
# which might not be reproducible in newer versions.
# internal bug number: 372274680
# external issue: https://github.com/grpc/grpc/issues/37710
'grpcio>=1.33.1,<2,!=1.48.0,!=1.59.*,!=1.60.*,!=1.61.*,!=1.62.0,!=1.62.1', # pylint: disable=line-too-long
'hdfs>=2.1.0,<3.0.0',
'httplib2>=0.8,<0.23.0',
'jsonschema>=4.0.0,<5.0.0',
Expand Down
6 changes: 6 additions & 0 deletions sdks/python/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,12 @@ deps =
pylint==2.17.5
isort==4.2.15
flake8==4.0.1
# https://github.com/grpc/grpc/issues/37660: ignore pip check
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tvalentyn let us skip pip check for lint.

commands_pre =
python --version
pip --version
# pip check
bash {toxinidir}/scripts/run_tox_cleanup.sh
commands =
pylint --version
time {toxinidir}/scripts/run_pylint.sh
Expand Down
Loading