Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@

## New Features / Improvements

* X feature added (Java/Python) ([#X](https://github.com/apache/beam/issues/X)).
* Support configuring Firestore database on ReadFn transforms (Java) ([#36904](https://github.com/apache/beam/issues/36904)).

## Breaking Changes

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,10 @@ private FirestoreStatefulComponentFactory() {}
* <p>The instance returned by this method is expected to bind to the lifecycle of a bundle.
*
* @param options The instance of options to read from
* @param configuredProjectId The project to target, if null, falls back to value in options.
* @param configuredDatabaseId The database to target, if null, falls back to value in options.
* @return a new {@link FirestoreStub} pre-configured with values from the provided options
*/
FirestoreStub getFirestoreStub(PipelineOptions options) {
return getFirestoreStub(options, null, null);
}

FirestoreStub getFirestoreStub(
PipelineOptions options,
@Nullable String configuredProjectId,
Expand Down
Loading
Loading