Skip to content

Conversation

@damccorm
Copy link
Contributor

@damccorm damccorm commented Dec 1, 2025

Creating a secret test resource every time leads to occasional synchronization failures (see #35832 (comment)). This fixes the problem.

Fixes #35832


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the python label Dec 1, 2025
@damccorm damccorm marked this pull request as ready for review December 1, 2025 22:00
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

Assigning reviewers:

R: @shunping for label python.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Collaborator

@shunping shunping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@shunping shunping merged commit cbc31be into master Dec 2, 2025
107 of 109 checks passed
@Amar3tto
Copy link
Collaborator

Amar3tto commented Dec 3, 2025

@damccorm should we cherrypick?

@damccorm damccorm deleted the users/damccorm/flaky-gbek branch December 3, 2025 14:28
@damccorm
Copy link
Contributor Author

damccorm commented Dec 3, 2025

If its causing failures on the release branch, then sure. But this was a fix for an occasional flake, so I think it is fine to leave if you're not seeing issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The PreCommit Python Transforms job is flaky

3 participants