[fix] remove in address2Region while bookie left to get correct rack info #4504
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
we use RegionAwareEnsemblePlacementPolicy in our pulsar cluster
We encountered some unexpected issues.
(In some situation, eg, Broker and bookie restart concurrently.)
address2Region
record X's region as default-region.onBookieRackChange
will only update address2Region for addresses present in knownBookies; therefore, bookie X's region info is not updated.which may cause traffic skew in ensemble selection, Causing the bookie disk to be filled up quickly.
Changes
We should ensure that when a bookie leaves the cluster, we also clean up the corresponding region information for that bookie in address2Region, so that it can update the correct region for the bookie during onBookieRackChange and
handleBookiesThatJoined.
do
leftBookies.forEach(address2Region::remove)
in handleBookiesThatLeft