-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BROOKLYN-166] Replace existing textareas for editing YAML with Composer Tab + Codemirror #1
Conversation
…irror Continuatiion of work started in apache/incubator-brooklyn#865 for BROOKLYN-166
- id: jquery-core:1.7.2 | ||
- id: swagger-ui:2.1.4 | ||
# we use other versions of the above in other projs | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this is an accidental reversion. the version numbers should be included. (you might want also to auto-regen the license file -- that also has some wanted new stuff removed but it's not a big deal.)
i've done the dull part, tomorrow i'll do the fun part, trying it out. thanks @m4rkmckenna @azbarcea! |
Nice work @m4rkmckenna @azbarcea . Merged (and combined all the license items as "codemirror" with a list of files.) It looks like we now have all the old functionality. A few things I think still need work: Important:
Nice to have:
Probably not worth it:
|
One more important item:
|
(This will help prevent autodetect mode problems, which happen for instance if you have a comment on a line before a |
Use new deleteable flag on bundles to give better info on the delete
Continuatiion of work started in apache/incubator-brooklyn#865 by @azbarcea for BROOKLYN-166