Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BROOKLYN-166] Replace existing textareas for editing YAML with Composer Tab + Codemirror #1

Merged
merged 4 commits into from
Feb 8, 2016

Conversation

m4rkmckenna
Copy link
Member

Continuatiion of work started in apache/incubator-brooklyn#865 by @azbarcea for BROOKLYN-166

- id: jquery-core:1.7.2
- id: swagger-ui:2.1.4
# we use other versions of the above in other projs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this is an accidental reversion. the version numbers should be included. (you might want also to auto-regen the license file -- that also has some wanted new stuff removed but it's not a big deal.)

@ahgittin
Copy link
Contributor

ahgittin commented Feb 4, 2016

i've done the dull part, tomorrow i'll do the fun part, trying it out. thanks @m4rkmckenna @azbarcea!

@m4rkmckenna
Copy link
Member Author

@ahgittin This PR does not address autocomplete ... thought it better to get the basic functionality in fist

Example of basic auto complete HERE

@asfgit asfgit merged commit 67bc3eb into apache:master Feb 8, 2016
asfgit pushed a commit that referenced this pull request Feb 8, 2016
@ahgittin
Copy link
Contributor

ahgittin commented Feb 8, 2016

Nice work @m4rkmckenna @azbarcea . Merged (and combined all the license items as "codemirror" with a list of files.)

It looks like we now have all the old functionality. A few things I think still need work:

Important:

  • Composer should indicate whether I'm adding to catalog or deploying
  • In wizard popup:
    • need a way to get to composer when not selecting a catalog item, ie writing new yaml (common user workflow)
    • "preview" button is not working; it could instead become "Open in Composer"
    • probably no need for the tabs?

Nice to have:

  • In composer, blueprint-to-deploy mode could have an option "open as catalog item"
  • In catalog, could have "Edit" mode for blueprints that have associated yaml (would be easy and very nice i think!)

Probably not worth it:

  • In composer, if in catalog mode, with a single item, we could have an "open as blueprint" mode

@ahgittin
Copy link
Contributor

ahgittin commented Feb 9, 2016

One more important item:

  • The dialog should track whether it is a catalog item or a blueprint. Otherwise someone might deploy when they intended to add to the catalog!

@ahgittin
Copy link
Contributor

ahgittin commented Feb 9, 2016

(This will help prevent autodetect mode problems, which happen for instance if you have a comment on a line before a brooklyn.catalog: line!)

@ahgittin
Copy link
Contributor

Changes are done in #5 and #7

tommclaughlan pushed a commit to diffusiondata/brooklyn-ui that referenced this pull request Jan 18, 2018
duncangrant pushed a commit to duncangrant/brooklyn-ui that referenced this pull request Oct 20, 2021
Use new deleteable flag on bundles to give better info on the delete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants