support handle on_received_messages failure of streaming rpc #1804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwbmmm
reviewed
Jun 20, 2022
| _s->id(), _storage, _size); | ||
| if (BAIDU_UNLIKELY(ret != 0)) { | ||
| LOG(WARNING) << "Fail to receive message for stream: " << _s->id(); | ||
| _s->_options.handler->on_failure(_s->id()); |
There was a problem hiding this comment.
I think it's unnecessary to call on_failure here. Since user knows what will return from on_received_messages, they can call on_failure in on_received_messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closed #1803
support handle
on_received_messagesfailure of streaming rpc, user can overloadon_failureofStreamInputHandlerto handleon_received_messagesfailure, the default is do nothing