Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set tags workers unlimitedly #2801

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Conversation

zhengJade
Copy link
Contributor

@zhengJade zhengJade commented Oct 29, 2024

What problem does this PR solve?

Issue Number:

Problem Summary: 设置 tag 对应的 worker 需要考虑 bthread_concurrency 和 bthread_min_concurrency,而且如果超过 bthread_concurrency 而又没有使用 bthread_min_concurrency 就无法正常设置 tag 对应的 worker 值,因为修改 bthread_concurrency 的值会直接平均分配给每一个 tag。

What is changed and the side effects?

Changed: 修改了增加 tag 对应 worker 的逻辑。

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@wwbmmm
Copy link
Contributor

wwbmmm commented Oct 30, 2024

@yanglimingcn 看看

@yanglimingcn
Copy link
Contributor

LGTM

@wwbmmm wwbmmm merged commit e1bf467 into apache:master Oct 31, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants