[CALCITE-6529] Use persistent sessionContext in AvaticaCommonsHttpClie… #249
+90
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaibudiu
approved these changes
Sep 13, 2024
|
The CI failed for macos |
caicancai
approved these changes
Sep 14, 2024
There was a problem hiding this comment.
Please modify the commit message and PR title to: [CALCITE-6529] xxxxx
stoty
reviewed
Sep 16, 2024
server/src/test/java/org/apache/calcite/avatica/server/HttpServerSpnegoWithoutJaasTest.java
Show resolved
Hide resolved
stoty
reviewed
Sep 16, 2024
| @@ -109,34 +110,33 @@ protected void initializeClient(PoolingHttpClientConnectionManager pool, | |||
| HttpClientBuilder httpClientBuilder = HttpClients.custom().setConnectionManager(pool) | |||
| .setDefaultRequestConfig(requestConfig); | |||
| this.client = httpClientBuilder.build(); | |||
|
|
|||
There was a problem hiding this comment.
have you tried setting these directly on the client object ?
There was a problem hiding this comment.
I have tried setting these directly on the client object, but I think it would require quite a lot of refactoring. For example, practically the whole AvaticaHttpClientFactoryImpl class should be rewritten.
There was a problem hiding this comment.
Good point.
Maybe in a followup ticket.
szucsvillo
changed the title
stoty
reviewed
Sep 18, 2024
core/src/main/java/org/apache/calcite/avatica/remote/AvaticaCommonsHttpClientImpl.java
Outdated
Show resolved
Hide resolved
| @@ -109,34 +110,33 @@ protected void initializeClient(PoolingHttpClientConnectionManager pool, | |||
| HttpClientBuilder httpClientBuilder = HttpClients.custom().setConnectionManager(pool) | |||
| .setDefaultRequestConfig(requestConfig); | |||
| this.client = httpClientBuilder.build(); | |||
|
|
|||
There was a problem hiding this comment.
Good point.
Maybe in a followup ticket.
|
Please fix the commit message to use square brackets, @szucsvillo . |
szucsvillo
force-pushed
the
CALCITE-6529
branch
from
bffba9d
to
dfe9f99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ntImpl